SNOW-1491028 : Snowflake JDBC Driver 4.2 compliant issue. #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sfc-gh-pmotacki @sfc-gh-dprzybysz , A Couple of Jenkins jobs are failing in this PR. Could you please confirm the reason behind this failures. Thanks. |
|
Hi @sfc-gh-ext-simba-vb , I checked and it's connected to problem with uploading to GCS, which results in one of our integration tests failure. Not really connected to this issue. |
sfc-gh-dheyman-1
approved these changes
Aug 7, 2024
src/test/java/net/snowflake/client/jdbc/ConnectionLatestIT.java
Outdated
Show resolved
Hide resolved
…into SNOW-1491028_Snowflake_JDBC_Driver_4.2_compl
sfc-gh-pmotacki
approved these changes
Aug 26, 2024
…into SNOW-1491028_Snowflake_JDBC_Driver_4.2_compl
…//github.com/snowflakedb/snowflake-jdbc into SNOW-1491028_Snowflake_JDBC_Driver_4.2_compl
sfc-gh-ext-simba-vb
deleted the
SNOW-1491028_Snowflake_JDBC_Driver_4.2_compl
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1491028
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Issue 1016 - https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/1016
Currently the setHoldability method always throws the exception. According to the docs we should throw the exception only when the given holdability is no supported - in other cases it should be no-op.
Now Driver will throw SnowflakeLoggedFeatureNotSupportedException only when holdability parameter is HOLD_CURSORS_OVER_COMMIT
If the connection is closed or given value is outside of the possible range in the standard, the driver will throw SQLException.